Fix float encoder overflow when float value itself over int range #412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jt2594838
approved these changes
Feb 18, 2025
java/tsfile/src/main/java/org/apache/tsfile/encoding/decoder/FloatDecoder.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #412 +/- ##
===========================================
+ Coverage 64.81% 64.90% +0.08%
===========================================
Files 545 545
Lines 33158 33029 -129
Branches 4416 4414 -2
===========================================
- Hits 21493 21438 -55
+ Misses 11123 11054 -69
+ Partials 542 537 -5 ☔ View full report in Codecov by Sentry. |
jt2594838
approved these changes
Feb 18, 2025
java/tsfile/src/main/java/org/apache/tsfile/encoding/encoder/FloatEncoder.java
Show resolved
Hide resolved
jt2594838
approved these changes
Feb 18, 2025
jt2594838
pushed a commit
that referenced
this pull request
Feb 18, 2025
* Fix float encoder overflow when float value itself over int range * fix double * Keep NaN (cherry picked from commit abfbfb8)
jt2594838
pushed a commit
that referenced
this pull request
Feb 19, 2025
ColinLeeo
pushed a commit
to ColinLeeo/tsfile
that referenced
this pull request
Apr 16, 2025
…ache#412) * Fix float encoder overflow when float value itself over int range * fix double * Keep NaN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.